add cli support for gerating Magic.Link authentication provider #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm noticing a typo in the commit message. Should I amend and force push or leave it? |
|
@gizmoGremlin excited to see this one get started! re: commit message typo --> all good to leave as is. Please let @cannikin know when this is ready for review. Thanks again! |
|
@cannikin This is ready for review. |
cannikin
approved these changes
Jun 2, 2020
|
Seems simple enough! Have you used the generator and got the login actually working properly? |
|
@cannikin Yes, I was able to create a magic.link signup in test mode using the magic.auth.loginWithMagicLink({ email }) method. |
|
LET'S DO IT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #623
Generators: Add auth generator for Magic.Link