-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-redwood-app): cli flags to show up help and version information #671
feat(create-redwood-app): cli flags to show up help and version information #671
Conversation
11d14f2
to
5123025
Compare
@jamesgeorge007 thanks for this! And great catch. This will be 100% needed sooner than later, for example, once the TypeScript support is complete and individuals can choose the installation language target. Your custom code looks great. But we've been using Yargs for the Redwood CLI (example file). Would you be interested in attempting to implement this with Yargs? Definitely open to discussion! And, at the very least, we could go ahead and move forward with merging this code and then following up with a Yargs improvement. Thoughts? |
Maybe we could onboard an arg-parser library, but IMHO it isn't necessary for a CLI utility of similar sort whose sole purpose is project scaffolding. |
At this time, the requirements are very simple indeed. But in the near future there are going to be increasing options for the type of installation:
The last reason is for consistency -- we're using Yargs everywhere else. Whether or not we do it now, we will end up using Yargs for this. All that said, I'm ok to proceed as is. But if you'd like to take a swing at Yargs, it's definitely of value and I (we) would support you as needed. What would you like to do as a next step? |
Let's land this one as of now and revisit the |
@jamesgeorge007 sounds good and the PR looks good. Merging now. Thanks again 🚀 |
Previously
create-redwood-app --help
would create a directory under the name--help
within the current path.