Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump latest Clerk version and fix broken import paths #6719

Closed

Conversation

SokratisVidros
Copy link

@Tobbe
Copy link
Member

Tobbe commented Oct 14, 2022

Someone else created a very similar PR earlier #6685 It touches the same file as this PR. Which one should we go with? 😅

@Tobbe Tobbe self-assigned this Oct 14, 2022
@noire-munich
Copy link
Collaborator

Thanks you for taking the time to do this @SokratisVidros .

As @Tobbe points out, we have 2 PRs addressing the same issue but not in the same way and both would require changes to be mergeable. There might be something to discuss with @stephenhandley about the use of the instance paths, either way from our side we will take the first one which will implement the strongest proposition (ideally: not using instance path and having updated deps).

Also, @SokratisVidros if you have a strong opinion on the use of instance paths we need to hear about it :).

@SokratisVidros
Copy link
Author

I am also posting this here: #6685 (comment)

@NicholasDevStore
Copy link

When can this issue be solved?

@SokratisVidros
Copy link
Author

@noire-munich Let's proceed with any of the two PRs.

@noire-munich
Copy link
Collaborator

When can this issue be solved?

Pretty soon, probably by end of next week.

@noire-munich noire-munich removed their assignment Oct 24, 2022
@jtoar
Copy link
Contributor

jtoar commented Nov 10, 2022

@NicholasDevStore we just released a fix for this issue in https://github.com/redwoodjs/redwood/releases/tag/v3.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

> 4.2.1 - Redwood JS API Server throws error
5 participants