Links: Use browser default behavior for ctrl-clicks etc

[Tobbe]

Fixes #676

[Tobbe]

This is not tested at all. I'd love to write a unit test, but how do I test that the browser opened the linked page in a new tab or window? I could possibly test that redwood's navigate is not called, but I thought that might be too much of an implementation detail rely on in a test

Also haven't tested it manually, see #678 and #679

[Tobbe]

Manually tested Ctrl- and Shift-clicking on Windows, both work as expected.

[thedavidprice]

Thanks for this @Tobbe! I looks good to me.

I've tested locally on Mac and can confirm the following works correctly now:

• cmd + click opens a new tab without changing changes
• shift + click opens in new window
• shift + cmd + click opens a new tab an changes to new tab
• option + click downloads HTML file

@peterp anything else you suggest here before merging?

I'd love to write a unit test, but how do I test that the browser opened the linked page in a new tab or window? I could possibly test that redwood's navigate is not called, but I thought that might be too much of an implementation detail rely on in a test

@RobertBroersma quick reactions to this case? Without EtoE I'm not sure what we could do. I’m ok to merge without unit test but wanted to check first.

[RobertBroersma]

It's a bit of an odd case to test I guess. Not sure what we could to besides checking navigate wasn't called either. I think it's fine to leave it manually tested only!