Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send logOut options to auth client #690

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Send logOut options to auth client #690

merged 3 commits into from
Jun 15, 2020

Conversation

dnprock
Copy link
Contributor

@dnprock dnprock commented Jun 12, 2020

No description provided.

@thedavidprice
Copy link
Contributor

@dnprock thank you for initiating this!

Background conversation here:
https://community.redwoodjs.com/t/auth0-logout-redirect/724

I've looped in @peterp for review.

@peterp peterp self-assigned this Jun 15, 2020
@peterp peterp added this to the next release milestone Jun 15, 2020
@peterp
Copy link
Contributor

peterp commented Jun 15, 2020

@dnprock Thanks for this! I'm busy with a refactor of authentication, so I've added your suggested changes over here: 0bc1b23

@peterp peterp merged commit 7767486 into redwoodjs:master Jun 15, 2020
@thedavidprice
Copy link
Contributor

@jtoar I just realized this might need a corresponding Auth Doc update -- could you put it on the list to confirm one way or the other? The background conversation is linked in my comment. See Peter's commit hash link for code.

Maybe this is just expected from Auth0 docs... I don't know ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants