Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup auth: No return on missing modules #7049

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Setup auth: No return on missing modules #7049

merged 1 commit into from
Dec 7, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 7, 2022

Throw an error if the error code is anything but MODULE_NOT_FOUND

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 7, 2022
@jtoar jtoar added the fixture-ok Override the test project fixture check label Dec 7, 2022
@Tobbe Tobbe enabled auto-merge (squash) December 7, 2022 18:52
@Tobbe Tobbe merged commit c273a47 into redwoodjs:main Dec 7, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Dec 7, 2022
@redwoodjs-bot
Copy link

redwoodjs-bot bot commented Dec 7, 2022

🔔 @jtoar, @Tobbe—I couldn't cherry pick this one. If you want it in the next release, you'll have to cherry pick it manually.

@Tobbe Tobbe deleted the tobbe-setup-auth-no-return branch December 7, 2022 19:34
@jtoar jtoar modified the milestones: next-release, v4.0.0 Dec 8, 2022
dac09 added a commit that referenced this pull request Dec 9, 2022
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/dc-kc-e…
d97d53b 
…xperimental-vite-optin

* 'main' of github.com:redwoodjs/redwood:
  Include dbAuth setup in test project fixture check (#7036)
  fix: dedupe redwoodjs packages (#7050)
  Setup auth: No return on missing modules (#7049)
  fix(deps): update dependency @fastify/static to v6.6.0 (#7029)
  Fix webAuthn import path in setup template (#7041)
  Fix typo in dbauth setup package name (#7040)
  chore(deps): update dependency nx to v15.3.0 (#7037)
  fix: auth provider names in setup auth (#7038)
  fix(deps): update dependency @fastify/url-data to v5.2.0 (#7030)
  fix(deps): update dependency eslint to v8.29.0 (#7031)
  fix(deps): update prisma monorepo to v4.7.1 (#7027)
  fix(deps): update storybook monorepo to v6.5.14 (#7028)
  chore(deps): update dependency @replayio/playwright to v0.3.10 (#7026)
  chore(auth): move auth providers into separate packages (#7019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar jtoar approved these changes

Assignees
No one assigned
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
Main
Status: Done
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tobbe @jtoar