Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typescript Parameter Properties not working #7084

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

gfpacheco
Copy link
Contributor

According to babel/babel#12066 preset-typescript should come after preset-env

According to babel/babel#12066 preset-env should come before preset-typescript
@gfpacheco gfpacheco changed the title Fix Typescript Parameter Properties not working fix: Typescript Parameter Properties not working Dec 9, 2022
@jtoar jtoar added the release:fix This PR is a fix label Dec 15, 2022
@jtoar jtoar self-assigned this Dec 15, 2022
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gfpacheco.

@jtoar jtoar merged commit 25c1d81 into redwoodjs:main Dec 19, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Dec 19, 2022
github-actions bot pushed a commit that referenced this pull request Dec 19, 2022
According to babel/babel#12066 preset-env should come before preset-typescript
jtoar pushed a commit that referenced this pull request Dec 19, 2022
According to babel/babel#12066 preset-env should come before preset-typescript
@gfpacheco gfpacheco deleted the patch-1 branch December 19, 2022 14:18
dac09 added a commit that referenced this pull request Dec 22, 2022
…xperimental-vite-optin

* 'main' of github.com:redwoodjs/redwood: (47 commits)
  chore(deps): update dependency @playwright/test to v1.29.1 (#7243)
  fix(deps): update prisma monorepo to v4.8.0 (#7242)
  chore(deps): update yarn to v3.3.1 (#7235)
  fix(deps): update storybook monorepo to v6.5.15 (#7237)
  cli generate helpers.js: Fix formatting warnings (#7238)
  fix(deps): update dependency @apollo/client to v3.7.3 (#7179)
  chore(deps): update dependency esbuild to v0.16.10 (#7230)
  chore(deps): update dependency @types/prettier to v2.7.2 (#7232)
  fix(deps): update typescript-eslint monorepo to v5.47.0 (#7223)
  explicitly reference dbAuth (#7226)
  fix: update packages in supabase setup (#7220)
  Fix Typescript Parameter Properties not working (#7084)
  fix: typo in clerk auth decoder import (#7219)
  chore(deps): update dependency esbuild to v0.16.9 (#7214)
  chore: update all contributors
  Update dependency react-hook-form to v7.41.0 (#7199)
  Update dependency lazy-get-decorator to v2.2.1 (#7208)
  Update dependency eslint to v8.30.0 (#7206)
  chore(deps): update dependency @playwright/test to v1.29.0 (#7204)
  chore(deps): update dependency esbuild to v0.16.8 (#7202)
  ...
jtoar pushed a commit that referenced this pull request Dec 22, 2022
According to babel/babel#12066 preset-env should come before preset-typescript
@jtoar jtoar modified the milestones: next-release-patch, v3.8.0 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants