Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing deps to cli helpers #7117

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fix: add missing deps to cli helpers #7117

merged 2 commits into from
Dec 12, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Dec 12, 2022

While reviewing #6956, I noticed more dependencies from @redwoodjs/cli-helpers that were missing. This PR adds them. If it's merged before #6956, I'll remove the duped packages there (just prompts right now).

The steps behind this are:

  • build the package
  • search through the package's dist for all require statement
  • is the required package listed in package.json's dependencies?

@jtoar jtoar requested a review from Tobbe December 12, 2022 20:28
@jtoar jtoar added release:fix This PR is a fix fixture-ok Override the test project fixture check labels Dec 12, 2022
@Tobbe Tobbe enabled auto-merge (squash) December 12, 2022 20:46
@jtoar jtoar disabled auto-merge December 12, 2022 21:03
@jtoar jtoar merged commit a9fc646 into main Dec 12, 2022
@jtoar jtoar deleted the ds-fix-cli-helpers-deps branch December 12, 2022 21:08
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Dec 12, 2022
@redwoodjs-bot
Copy link

redwoodjs-bot bot commented Dec 12, 2022

🔔 @jtoar, @Tobbe—I couldn't cherry pick this one. If you want it in the next release, you'll have to cherry pick it manually.

dac09 added a commit that referenced this pull request Dec 13, 2022
….com:redwoodjs/redwood into feat/dc-kc-decoupled-auth-setup-improvements

* 'feat/dc-kc-decoupled-auth-setup-improvements' of github.com:redwoodjs/redwood:
  chore(deps): update dependency nx to v15.3.2 (#7114)
  chore(deps): update dependency redis to v4.5.1 (#7115)
  fix: add missing deps to cli helpers (#7117)
  Adds ability to delete a cache entry (#7016)
  Label override flags for dbAuth generator (#6440)
  fix(deps): update dependency systeminformation to v5.16.6 (#7108)
  feat: Generator rollbacks  (#6947)
  fix(deps): update dependency @types/node to v16.18.8 (#7107)
  chore(deps): update dependency supertokens-node to v12.1.3 (#7105)
@jtoar jtoar modified the milestones: next-release, v4.0.0 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants