Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): check if we're rendering in an iframe before scrolling #7175

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Dec 15, 2022

Fixes #7171.

@jtoar jtoar added the release:fix This PR is a fix label Dec 15, 2022
@jtoar jtoar self-assigned this Dec 15, 2022
Copy link

@jan-stehlik jan-stehlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jtoar 🚢

@jtoar jtoar merged commit 6722c82 into main Dec 15, 2022
@jtoar jtoar deleted the ds-disable-scroll-to-top-in-iframe branch December 15, 2022 18:01
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Dec 15, 2022
github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
…7175)

* fix: check if rendering in an iframe

* chore: add context

* chore: move to util, add back try catch and source
jtoar added a commit that referenced this pull request Dec 15, 2022
…7175)

* fix: check if rendering in an iframe

* chore: add context

* chore: move to util, add back try catch and source
jtoar added a commit that referenced this pull request Dec 15, 2022
…7175)

* fix: check if rendering in an iframe

* chore: add context

* chore: move to util, add back try catch and source
@jtoar jtoar modified the milestones: next-release-patch, v3.7.1 Dec 15, 2022
jtoar added a commit that referenced this pull request Dec 15, 2022
…7175)

* fix: check if rendering in an iframe

* chore: add context

* chore: move to util, add back try catch and source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug?]: Parent page autoscrolls to iframed redwood app
2 participants