Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Change custom authHeader to return type #720

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Suggestion: Change custom authHeader to return type #720

merged 1 commit into from
Jun 19, 2020

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Jun 19, 2020

Suggestion: Return the type of unknown token so that it can be handled in api/src/lib/auth.js

Why?
For example, you might want to support multiple types of auth within the same redwood api. In our case we use both JWT and an opaque token

Relevant discussion: Community discussion


Please note I am unable to test it with 0.11 - copy:watch isn't work for me, however I have been using patch-package in 0.10 with this code successfully

Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@peterp
Copy link
Contributor

peterp commented Jun 19, 2020

@dac09 Thanks so much for this, could you open a ticket for copy:watch? I'll get that fixed for you ASAP

@dac09
Copy link
Collaborator Author

dac09 commented Jun 19, 2020

@dac09 Thanks so much for this, could you open a ticket for copy:watch? I'll get that fixed for you ASAP

Hey Peter, copy:watch issue looks related to 0.11 I think! Posted on the discord help channel :)

@thedavidprice
Copy link
Contributor

@dac09 Thanks for this! re: Error --> could you please open an Issue here? We're not able to dive too deep on Discord, unfortunately.

@peterp peterp self-assigned this Jun 19, 2020
@peterp peterp changed the base branch from master to main June 19, 2020 15:32
@dac09
Copy link
Collaborator Author

dac09 commented Jun 19, 2020

@dac09 Thanks for this! re: Error --> could you please open an Issue here? We're not able to dive too deep on Discord, unfortunately.

Raised issue #726, with solution from peterp!

@peterp peterp added this to the next release milestone Jun 19, 2020
@peterp peterp merged commit dfafa19 into redwoodjs:main Jun 19, 2020
@dac09 dac09 deleted the feature/more-open-custom-auth branch June 19, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants