fix(import-dir): Ignore file extensions | Ignore .test files #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WOW 🤩 , Thank you! |
peterp
reviewed
Jun 24, 2020
Comment on lines
61
to
64
| const filePathWithoutExtension = path.join( | ||
| parsedPath.dir, | ||
| parsedPath.name | ||
| ) |
There was a problem hiding this comment.
node imports paths are normalized across operating systems, so I don't think we need to use path.join() here, instead .join('/') should be enough.
|
It might be a good idea to update the default scaffold to use the dir-import instead of |
You're right, it's probably time, and then we can remove importAll.macro from the api side! That needs to be done over here: https://github.com/redwoodjs/create-redwood-app/blob/main/api/src/functions/graphql.js |
peterp
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes redwood dir importer babel plugin to:
Community Discussion Reference