API: Fix for function based context to run on each request #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per discussion in this thread, https://community.redwoodjs.com/t/context-function-passed-to-creategraphqlhandler-runs-only-once-on-first-request/801 context function passed to createGraphQLHandler was running only once, after some debugging it seems function was overwritten with the data return from that custom context function
|
@nexneo Thanks for this, amazing! |
peterp
approved these changes
Jun 30, 2020
|
Thanks @peterp contributing to Redwood was super simple with help of this Guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in this thread, https://community.redwoodjs.com/t/context-function-passed-to-creategraphqlhandler-runs-only-once-on-first-request/801
context function passed to
createGraphQLHandlerwas running only once, after some debugging it seems function was overwritten with the data return from that same context function.With this change you can pass context as function and will run on every request, which is super useful if you are implementing custom authentication for legacy reasons.
Thanks!