Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generated relational arrays #772

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

Rosenberg96
Copy link
Contributor

Closes #741
Closes #740

Ammends #747

This PR fixes the format of the generated relational arrays

@mohsen1
Copy link
Contributor

mohsen1 commented Jun 30, 2020

Here is how it works:

foo: String

is foo: string | null

foo: String!

is foo: string

foo: [String]

is foo: (string | null)[] | null

foo: [String]!

is foo: (string | null)[]

foo: [String!]!

is foo: string[]

@cannikin cannikin merged commit d3710ff into redwoodjs:main Jun 30, 2020
@cannikin
Copy link
Member

Thanks for that fix !

@thedavidprice thedavidprice added this to the next release milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants