Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update webhook links #7934

Merged
merged 4 commits into from Mar 27, 2023
Merged

fix(docs): Update webhook links #7934

merged 4 commits into from Mar 27, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Mar 27, 2023

Fixes #7929 and fixes #7930

Problem
Please see the issues linked. There was an outdated third party linked and some of the links to framework code pointed to a fork rather than the main repository.

Changes

  1. Removed link to automate.io - see article
  2. Switched links from @dthyresson's fork to the main repo
  3. Removed a duplicate entry in the SupportedVerifiers type union

@Josh-Walker-GM Josh-Walker-GM added the release:docs This PR only updates docs label Mar 27, 2023
@dthyresson
Copy link
Contributor

Thanks @Josh-Walker-GM !

@dthyresson dthyresson merged commit 8be21c8 into main Mar 27, 2023
30 checks passed
@dthyresson dthyresson deleted the jgmw-docs-webhooks branch March 27, 2023 15:16
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 27, 2023
Copy link
Contributor

@dthyresson dthyresson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jtoar jtoar modified the milestones: next-release, v5.0.0 Mar 27, 2023
@adriatic
Copy link
Contributor

No thanks to me, @dthyresson ?

@dthyresson
Copy link
Contributor

Thanks for reporting @adriatic

@adriatic
Copy link
Contributor

That was just a small tease @dthyresson 😄

jtoar pushed a commit that referenced this pull request Mar 27, 2023
* Remove automate.io link

* Fix signatureVerifiers link and list

* Fix other webhook links

---------

Co-authored-by: David Thyresson <dthyresson@gmail.com>
@jtoar jtoar modified the milestones: next-release, v4.5.0 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove automate.io from Webhooks documentation Link referencing the definition of signatureVerifiers is bad
4 participants