Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-vite): Also transform jsx Cell files #8030

Merged
merged 1 commit into from Apr 7, 2023

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Apr 7, 2023

What's the problem?

If you had a cell named like this MyCell.jsx the babel transform wouldn't pick it up, because we were only looking for js or tsx files.

Fix

Just add jsx to the list of extensions to match against

@dac09 dac09 added the release:fix This PR is a fix label Apr 7, 2023
@dac09 dac09 enabled auto-merge (squash) April 7, 2023 06:48
@replay-io
Copy link

replay-io bot commented Apr 7, 2023

16 replays were recorded for 7911feb.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/04b01a44-d2f5-4658-92cf-d3aacd00852f>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/f25712dc-7794-4458-aed9-c1ee9cf1d1b2>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/5d23b01f-d4f8-409f-bd7c-6d2c27762ccc>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/ab2a735b-6773-4581-b540-505eb4029b57>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/ffd3efc6-0b7f-4922-b877-f279e2420f54>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/a8502cda-0883-4d0b-9e53-150ea46bb932>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/cbfd1c1e-594f-4407-8bcf-d2305ea6b505>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/55ec245a-f0b8-4e76-8fc1-30bf10ebafbe>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/b4115b9b-31b6-4e5e-9aee-79edd2ec78c2>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/d51fb3cd-9a92-4d36-8ea1-f8d3a27bac36>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/99925645-a906-497d-b213-e58c0c0eac71>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/b483313d-93b3-4363-a0b6-e83ed50835ca>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/92a6f896-e7f1-4194-aa34-aa6fe604ac3b>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/cdb185ae-252e-4030-84fd-92db65eb6c3f>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/ab94e3eb-8d18-416a-bb56-d4b4df207627>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@dac09 dac09 merged commit 6db7133 into redwoodjs:main Apr 7, 2023
30 of 32 checks passed
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Apr 7, 2023
@dac09 dac09 deleted the fix/babel-cell-jsx branch April 7, 2023 11:42
@jtoar jtoar modified the milestones: next-release, v4.5.0 Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants