Add @storybook/react to @redwoodjs/core #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is perfect, thanks! |
peterp
approved these changes
Jul 9, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
@storybook/reactpackage to@redwood/core. Let me know if this isn't necessary, but I didn't see storybook as a dependency, even though we require it in packages/core/config/storybook/preview.js:Also, even when I upgrade one of my local Redwood apps to canary, I have to install it myself (i.e. run
yarn workspace web add -D @storybook/react).yarn rw storybookfails otherwise ("missing command start-storybook"). Maybe this is why?Last question: ideally it should be a dev dependency in Redwood app's web side right?