Make MockRouter also map private routes. #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertBroersma
approved these changes
Jul 10, 2020
|
|
||
| const FakePage = () => <></> | ||
|
|
||
| describe('MockRouter', () => { |
| export * from '@redwoodjs/router/dist/index' | ||
|
|
||
| export const routes: { [routeName: string]: () => string } = {} | ||
|
|
||
| const getPrivateRoutes = (children: React.ReactNode) => |
There was a problem hiding this comment.
Do you expect any other nested type of routes in the Router in the (near) future? If so it could be worthwhile to make the function recursively look for routes?
If not, ignore me!
There was a problem hiding this comment.
I don't think so, we really want to keep it flat, but this might be a great place to adopt the @redwoodjs/structure's implementation instead of duplicating it across Routers.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
MockRouternot correctly mappingRoutesnested inPrivate.