TLC for scaffold details/show page #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good to me. Was also thinking through any backwards compatibility issues and didn't see anything to that end.
Looping in @cannikin for final approval.
cannikin
approved these changes
Jul 14, 2020
|
@thedavidprice Seems both you and @cannikin approves of this. Mind using that 🚨 button again? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details view you get to if you click "show" on the overview/list page generated by the scaffolds needed some TLC. The titles/headings needed to be humanized, as they are for all other pages (overview, edit, new). And the boolean and date values needed formatting.
Before
After