Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rebuild-fixture): add temporary step for Storybook v7 #8406

Merged
merged 2 commits into from
May 25, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 24, 2023

For yarn build:test-project --rebuild-fixture to work at the moment with the Storybook v7 changes in, we need to add storybook as a dependency to the web side. This PR makes it so that rebuilding the fixture adds it so it doesn't get removed. We could also upgrade the test project fixture to canary like we did when we decoupled auth. @Tobbe you've had some experience with the two I think. Which do you prefer?

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label May 24, 2023
@replay-io
Copy link

replay-io bot commented May 24, 2023

19 replays were recorded for 2729152.

image 0 Failed
image 19 Passed

View test run on Replay ↗︎

@jtoar
Copy link
Contributor Author

jtoar commented May 25, 2023

Spoke with Tobbe and he's ok with this implementation.

@jtoar jtoar merged commit 4598521 into main May 25, 2023
4 checks passed
@jtoar jtoar deleted the ds-storybook/update-to-rebuild-fixture branch May 25, 2023 20:09
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 25, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant