fix(type defs): log type-def generation errors at the end #8448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4 replays were recorded for 75f2bfb.
|
jtoar
force-pushed
the
ds-type-gen/fix-error-output
branch
from
e6b9d47
to
cc773d7
Compare
|
I have to update a few other generators here too:
|
dac09
approved these changes
Jun 19, 2023
|
@jtoar going to leave to you to merge, but fixed the type issue! |
jtoar
added a commit
that referenced
this pull request
Jun 29, 2023
* fix(dx): log errors later * fix test, use better var names * change test name * simplify generateTypeDefGraphQLWeb * fix code gen test * stop logging empty line * add error logging to generators too * Fix final type issue * try mocking generate --------- Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8423. This just replaces all calls to
console.errorwitherrors.pushin the type defgeneratefunction and all the functions it calls, and logs all the errors at the end. It results in a lot of changes to return types. Let me know if there's a better way to do this, this is just what made the most sense in the shortest amount of time.Example: