Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleans up server template for realtime #8487

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

dthyresson
Copy link
Contributor

With the last PR merged for realtime, I forgot to clean up the server file template so a few bits that are not needed unfortunately snuck in.

This removes:

  • Operation node types not needed
  • some live query comments
  • whitespacing

@dthyresson dthyresson added the release:chore This PR is a chore (means nothing for users) label Jun 1, 2023
@dthyresson dthyresson self-assigned this Jun 1, 2023
@dthyresson dthyresson marked this pull request as ready for review June 1, 2023 19:07
@replay-io
Copy link

replay-io bot commented Jun 1, 2023

19 replays were recorded for 03695ae.

image 0 Failed
image 19 Passed

View test run on Replay ↗︎

Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode will want a line between 'path' and 'chalk' but apart from that we're good.

…plate

Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
@dthyresson dthyresson enabled auto-merge (squash) June 1, 2023 19:32
@jtoar jtoar disabled auto-merge June 1, 2023 19:38
@jtoar jtoar merged commit 4d851ee into redwoodjs:main Jun 1, 2023
25 checks passed
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 1, 2023
jtoar pushed a commit that referenced this pull request Jun 2, 2023
* Cleans up server template for realtime

* Update packages/cli/src/commands/experimental/templates/server.ts.template

Co-authored-by: Josh GM Walker <56300765+Josh-Walker-GM@users.noreply.github.com>
@jtoar jtoar modified the milestones: next-release, temp, v6.0.0 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants