chore(ci): use canary version of rwjs vite #8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like multiple reasons why CI was failures, and you got them all here @jtoar! ✅ Cypress wasn't being installed 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8471 added a new binary to a redwoodjs package. Our current tooling (
yarn rwfw project:deps, copy sync) alone doesn't handle this use case. Instead we need the package with the binary to be installed, so I'm bumping@redwoodjs/viteto canary to see if it fixes it. If it does, I'll have to add a step to rebuilding the test project to persist this fix till we release the next major.