Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .js files to .jsx #8537

Merged
merged 85 commits into from
Jun 14, 2023
Merged

Update .js files to .jsx #8537

merged 85 commits into from
Jun 14, 2023

Conversation

@cannikin cannikin requested a review from dac09 June 6, 2023 21:21
@cannikin cannikin self-assigned this Jun 6, 2023
@cannikin
Copy link
Member Author

cannikin commented Jun 6, 2023

@Josh-Walker-GM Could you help out with an issue I'm having? The scaffold destroy tests have two failures. There's a test that checks if the number of files returned from the scaffold generator matches the number of times that a mock for unlinkSync is called to delete the files. There's 15 files coming back, but only 4 mock calls to delete:

image

Even weirder is that these two tests are for the TS version of the scaffolded files, which I didn't even mess with: I just changed the .js extension to .jsx. I'm at a loss!

@Josh-Walker-GM
Copy link
Collaborator

@cannikin sure I can take a look

@cannikin
Copy link
Member Author

cannikin commented Jun 6, 2023

Thank you! The two tests that are failing:

https://github.com/redwoodjs/redwood/blob/rc-jsx/packages/cli/src/commands/destroy/scaffold/__tests__/scaffoldNoNest.test.js#L157
https://github.com/redwoodjs/redwood/blob/rc-jsx/packages/cli/src/commands/destroy/scaffold/__tests__/scaffold.test.js#L159

I actually found 2 files that weren't being updated to .jsx (formatters and formatters.test) and now the disparity is:

Expected: 2
Received: 13

@cannikin cannikin added the release:feature This PR introduces a new feature label Jun 6, 2023
@cannikin
Copy link
Member Author

cannikin commented Jun 6, 2023

@dac09 Is this actually feature-breaking or are we just showing a deprecation notice for the initial release?

@dac09 dac09 closed this Jun 13, 2023
@dac09 dac09 reopened this Jun 13, 2023
Copy link
Collaborator

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Thanks Rob & Josh!

@dac09 dac09 enabled auto-merge (squash) June 13, 2023 03:57
@dac09 dac09 modified the milestones: next-release, v6.0.0 Jun 14, 2023
@dac09 dac09 merged commit cd34b8b into main Jun 14, 2023
27 checks passed
@dac09 dac09 deleted the rc-jsx branch June 14, 2023 04:18
@redwoodjs-bot redwoodjs-bot bot modified the milestones: v6.0.0, next-release Jun 14, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants