chore(cli-storybook): improve types, style changes #8555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add some types - add type dev dep - style for build.mjs file and command module
Josh-Walker-GM
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Nice. Happy with all these and thanks for the types! I just wasn't sure how to approach them with yargs specifically.
I prefer functions over arrow functions in most cases too! I was just following the existing pre split out styling where they're all arrow functions.
Good idea about putting it in as a task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Josh-Walker-GM here's a small set of changes to the cli-storybook package after our discussion earlier. I think the types could still be better, or at least I could be more confident in them, but what's in this PR is probably better than before. Most of this PR is just style changes though, and I thought I'd get those out of the way before we start moving other commands over.
I took a small crack at adding dependency cruiser, and adding it to every package.json seems like overkill, so I'm going to try making that into a script in
tasks/.Style changes: