Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setup ui windicss (project is sunsetting) #8598

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Conversation

thedavidprice
Copy link
Contributor

PR 2 of 2

This PR removes the setup ui windicss command entirely. (target v6)

The WindiCSS project is sunsetting. One of the recommended replacements is Tailwind CSS, which is already supported. See: https://windicss.org/posts/sunsetting.html

In #8597 setup ui windiness was deprecated in the setup command and CLI docs. (target v5.4)


Breaking Notes
This PR is not technically breaking although it removes functionality from the command line setup options.

Projects using Windi CSS will not be affected when upgrading. Redwood v6 switches to Vite as the default bundler (Webpack supported but deprecated). At that time, if projects using Windi CSS upgrade to v6 and want to use Vite, they'll need to follow the Windi + Vite installation guide to manually make the changes to upgrade: https://windicss.org/integrations/vite.html

@thedavidprice thedavidprice added the release:breaking This PR is a breaking change label Jun 13, 2023
@thedavidprice thedavidprice added this to the v6.0.0 milestone Jun 13, 2023
@thedavidprice thedavidprice requested a review from jtoar June 13, 2023 05:16
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's get #8597 in first

@jtoar jtoar added the fixture-ok Override the test project fixture check label Jun 13, 2023
@jtoar jtoar merged commit d9797bd into main Jun 14, 2023
9 of 10 checks passed
@jtoar jtoar deleted the dsp-remove-windi-css-v6 branch June 14, 2023 19:05
@redwoodjs-bot redwoodjs-bot bot modified the milestones: v6.0.0, next-release Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:breaking This PR is a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants