chore(CI): test webpack in tutorial e2e #8602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
commented
Jun 13, 2023
| runs-on: ${{ matrix.os }} | ||
| bundler: [vite, webpack] | ||
|
|
||
| name: 🌲 Tutorial E2E / ${{ matrix.bundler }} / node 18 latest |
There was a problem hiding this comment.
I've included the bundler in the check's name so I'll have to change the branch protection rules to accommodate
jtoar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a matrix to the tutorial e2e test in CI so that we run both vite and webpack. Now I'll direct my attention to the smoke tests.