Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(smoke-tests): make smoke tests easier to run locally #8607

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jun 14, 2023

@Tobbe tried to run the smoke tests locally last week and ran into some trouble since I didn't fix how we run them locally after making my changes in #8449. This PR fixes that by adding a script in tasks that runs smoke tests somewhat interactively:

smoke-tests.mov

A few more note:

  • I added back the env var PROJECT_PATH. I still think it's too vague, but I shouldn't have broken the way it works
  • I didn't show it in the video to save time, but I made "all" an option to run all the smoke tests. It just runs them one after another. No more reading interleaved logs
  • This script even warns you if you forgot to build before running prerender or serve!
  • Nice help output via --help or -h:
image

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Jun 14, 2023
@jtoar jtoar requested a review from Tobbe June 14, 2023 02:26
@Tobbe Tobbe enabled auto-merge (squash) June 16, 2023 17:26
@Tobbe Tobbe merged commit 07f130c into main Jun 16, 2023
27 checks passed
@Tobbe Tobbe deleted the ds-tasks/smoke-tests branch June 16, 2023 18:09
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 16, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants