fix(vite): list imports before dns call #8620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think it should be ok, if the smoke tests pass - we're fine! But the fixture does need to be updated (manually or otherwise :)) I'll pick up tomorrow if you don't get to it first! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dac09 does the call to
dns. setDefaultResultOrderneed to come before the@redwoodjs/viteimport? If so we should probably make that a little clearer because I installed a Vite plugin and re-ordered the imports thinking it didn't matter. If it doesn't matter, ok if we just list all the imports first?