fix(publishing): remove tsconfig.tsbuildinfo #8637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
added a commit
that referenced
this pull request
Jun 15, 2023
jtoar
added a commit
that referenced
this pull request
Jun 15, 2023
|
Just tried this out in a patch and it doesn't work; the lerna publish step builds the packages again, putting the tsconfig.tsbuildinfo file there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the contents of
@redwoodjs/tui's dist, and most of the files are only a few kilobytes. But one,tsconfig.tsbuildinfo, is ~75 kilobytes—several times larger than the rest of the files combined. It's still not that big in the scheme of things (i.e. compared to most dependencies), but it struck as me being completely unnecessary since this file is for speeding up TypeScript's build's step (source: https://www.typescriptlang.org/tsconfig#tsBuildInfoFile).Source: https://www.npmjs.com/package/@redwoodjs/tui?activeTab=code
Since this file is to make incremental builds with TS faster, we can't just delete it after we build packages. But we can delete it before we publish, so that's what this PR does.