-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): Change config for mantine and chakra to use export default #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thedavidprice want to try this out in your branch? Simple change :) |
dac09
added
release:fix
This PR is a fix
fixture-ok
Override the test project fixture check
labels
Jun 16, 2023
thedavidprice
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test QA for both chakra and mantine is ✅
Note: I did not do QA on codemod — leaving that to you.
Thanks! 🚀
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 21, 2023
…redwood into codemod/replace-svg-as-components * 'codemod/replace-svg-as-components' of github.com:dac09/redwood: chore(deps): update react monorepo (redwoodjs#8677) chore(deps): update dependency postcss to v8.4.24 (redwoodjs#8675) chore(deps): update dependency esbuild to v0.18.6 (redwoodjs#8670) chore(deps): update dependency dependency-cruiser to v13.0.4 (redwoodjs#8674) chore(deps): update dependency autoprefixer to v10.4.14 (redwoodjs#8668) chore(deps): update dependency @clerk/clerk-react to v4.20.5 (redwoodjs#8672) Fix typos in documentation (redwoodjs#8659) fix(docs): Fix & make verifyOwnership consistent (redwoodjs#8596) chore(deps): update dependency vite to v4.1.5 [security] (redwoodjs#8671) fix(deps): update dependency react-hook-form to v7.45.0 (redwoodjs#8664) chore(studio): update tremor to v3 (redwoodjs#8645) fix(deps): update dependency webpack to v5.87.0 (redwoodjs#8549) fix(deps): update dependency dotenv to v16.3.1 (redwoodjs#8663) chore(deps): update dependency @clerk/clerk-react to v4.20.4 (redwoodjs#8662) fix(vite): Change config for mantine and chakra to use export default (redwoodjs#8639) fix(deps): update storybook monorepo to v7.0.22 (redwoodjs#8652) Fix failing v5 codemod for DevFatalErrorPage (redwoodjs#8661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the templates for Chakra UI and Mantine, to avoid using
module.exports
which is not supported in Vite (because its commonjs)Note: not changing tailwind because tailwind is used differently. I think it was incorrect for us to place mantine and chakra config in the config folder - because it's actually imported in the app (it's a source file, not config), where as tailwind is not.
For release notes (existing users):
If you're using Chakra or Mantine, you will need to update how these libraries are configured. You might see this error in your browser console:
To fix this you'll need to make sure you're not using
module.exports
in yourweb/config/mantine.config.js
orweb/config/chakra.config.js
.Codemod available:
Manual steps:
The change is simple: