Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Fix playwright timeout #8687

Merged
merged 3 commits into from
Jun 22, 2023
Merged

chore(ci): Fix playwright timeout #8687

merged 3 commits into from
Jun 22, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM commented Jun 22, 2023 •
edited
Loading

WIP Debugging

Notes

  • CI is failing on various PRs typically with a timeout on the broken gql prerender task.
  • Appears to be on windows
    • I ran locally on windows and cannot reproduce
    • Timeout on CI is 30s but even locally that specific broken gql test takes 12.5s (maybe just slow)
  • It also looks like the test 'Check that rehydration works for page with code split chunks' always times out the first time? The second try is only ~300ms though so 🤔

Changes

  • Add test.slow to broken gql test
    • Should we conditionally mark this slow on windows only? Looks like ~20s on linux so let's just unconditionally mark this a slow one
    • For reference .slow means the timeout for that specific test is 3x the normal timeout

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label Jun 22, 2023
@jtoar jtoar marked this pull request as ready for review June 22, 2023 19:13
@jtoar jtoar merged commit aae5825 into main Jun 22, 2023
5 checks passed
@jtoar jtoar deleted the jgmw-ci/debug-playwright branch June 22, 2023 20:26
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 22, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Jun 23, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into codemod/repl…
b9bbfdc 
…ace-svg-as-components

* 'main' of github.com:redwoodjs/redwood: (25 commits)
  fix(deps): update dependency @whatwg-node/fetch to v0.9.7 (redwoodjs#8702)
  fix(deps): update dependency @heroicons/react to v2.0.18 (redwoodjs#8701)
  fix(deps): update dependency @headlessui/react to v1.7.15 (redwoodjs#8700)
  fix(deps): update dependency webpack to v5.88.0 (redwoodjs#8697)
  fix(deps): update dependency @graphiql/toolkit to v0.8.4 (redwoodjs#8698)
  fix(deps): update dependency react-error-boundary to v4.0.10 (redwoodjs#8693)
  Rename cache file (redwoodjs#8699)
  fix(clerk): add alternative decoder (redwoodjs#8642)
  fix(deps): update dependency @vitejs/plugin-react to v4.0.1 (redwoodjs#8692)
  chore(deps): update dependency @simplewebauthn/server to v7.3.1 (redwoodjs#8690)
  chore(rwfw): Add force optimise to vite.config when running project:sync (redwoodjs#8688)
  fix(deps): update storybook monorepo to v7.0.23 (redwoodjs#8696)
  fix(deps): update dependency react-toastify to v9.1.3 (redwoodjs#8694)
  fix(deps): update prisma monorepo to v4.16.1 (redwoodjs#8695)
  Mark broken gql prerender test as slow (redwoodjs#8687)
  fix(deps): update dependency @graphiql/plugin-explorer to v0.1.20 (redwoodjs#8691)
  fix(deps): update typescript-eslint monorepo to v5.60.0 (redwoodjs#8660)
  fix(deps): update dependency @fastify/http-proxy to v9.2.1 (redwoodjs#8680)
  chore(deps): update dependency vite to v4.3.9 (redwoodjs#8682)
  fix(deps): update prisma monorepo to v4.16.0 (redwoodjs#8684)
  ...
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtoar jtoar Awaiting requested review from jtoar

Assignees
No one assigned
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Josh-Walker-GM @jtoar