Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vite): Remove references to webpack, and more docs on SVGs and fonts #8707

Merged
merged 15 commits into from
Jun 26, 2023

Conversation

dac09
Copy link
Collaborator

@dac09 dac09 commented Jun 23, 2023

Docs changes only!

  1. Removes references to webpack
  2. Replace with Vite instructions
  3. Adds extra section on how to style SVGs (we didn't have this before)
  4. Adds extra section for a tip on how to use @font-face rules

@dac09 dac09 added release:docs This PR only updates docs fixture-ok Override the test project fixture check labels Jun 23, 2023
@dac09 dac09 added this to the v6.0.0 milestone Jun 23, 2023
@dac09 dac09 changed the title docs(vite): Remove references to webpack docs(vite): Remove references to webpack, and more docs on SVGs and fonts Jun 23, 2023
docs/docs/assets-and-files.md Outdated Show resolved Hide resolved
docs/docs/assets-and-files.md Outdated Show resolved Hide resolved
docs/docs/assets-and-files.md Outdated Show resolved Hide resolved
docs/docs/assets-and-files.md Show resolved Hide resolved
docs/docs/assets-and-files.md Outdated Show resolved Hide resolved
docs/docs/cli-commands.md Show resolved Hide resolved
docs/docs/tutorial/chapter1/second-page.md Outdated Show resolved Hide resolved
docs/docs/vite-configuration.md Outdated Show resolved Hide resolved
docs/docs/vite-configuration.md Outdated Show resolved Hide resolved
@Tobbe
Copy link
Member

Tobbe commented Jun 24, 2023

Great tone in all these docs Danny! Well written 🖊️

As always, feel free to challenge all my review comments 🙂

docs/docs/assets-and-files.md Outdated Show resolved Hide resolved
dac09 and others added 3 commits June 26, 2023 10:10
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Copy link
Member

@Tobbe Tobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dac09 dac09 enabled auto-merge (squash) June 26, 2023 08:52
@dac09 dac09 merged commit 1aa8bea into redwoodjs:main Jun 26, 2023
28 checks passed
@redwoodjs-bot redwoodjs-bot bot modified the milestones: v6.0.0, next-release Jun 26, 2023
@dac09 dac09 deleted the docs/webpack-refs branch June 26, 2023 12:50
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants