Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Add experimental notice when rw dev uses server file #8723

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

When you are using the experimental server file and run yarn rw serve we print a notice to ensure you're aware your're using the experimental server file.

I enabled yarn rw dev to use the server file but forgot to add a similar notice. It's not easy to tell which mode the dev server is running in if you're experimenting with the server file. This PR just adds the same notice so there is consistency.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Jun 24, 2023
Copy link
Member

@Tobbe Tobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
image

@Josh-Walker-GM Josh-Walker-GM removed the request for review from jtoar June 26, 2023 22:18
@Josh-Walker-GM Josh-Walker-GM enabled auto-merge (squash) June 26, 2023 22:19
@jtoar jtoar disabled auto-merge June 26, 2023 22:48
@jtoar jtoar merged commit cf4c87b into main Jun 26, 2023
17 checks passed
@jtoar jtoar deleted the jgmw-cli/dev-exp-serverfile-notice branch June 26, 2023 22:49
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 26, 2023
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants