Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vite unless bundler === webpack #8731

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Use vite unless bundler === webpack #8731

merged 3 commits into from
Jun 26, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jun 25, 2023

Vite should be the default. So the only way to use webpack should be to have bundler === 'webpack'. As soon as bundler !== 'webpack' we use vite

@Tobbe Tobbe requested review from Josh-Walker-GM and dac09 and removed request for Josh-Walker-GM June 25, 2023 16:38
@Tobbe Tobbe added the release:fix This PR is a fix label Jun 25, 2023
@dac09 dac09 enabled auto-merge (squash) June 26, 2023 03:05
@dac09 dac09 merged commit 619977f into redwoodjs:main Jun 26, 2023
28 checks passed
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jun 26, 2023
@Tobbe Tobbe deleted the tobbe-vite-bundler-check branch June 26, 2023 07:45
@jtoar jtoar modified the milestones: next-release, v6.0.0 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dac09 dac09 dac09 approved these changes

Assignees
No one assigned
Labels
release:fix This PR is a fix
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tobbe @dac09 @jtoar