Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Storybook Template files to for CSF 3 #8788

Merged
merged 19 commits into from
Jul 6, 2023

Conversation

ahaywood
Copy link
Contributor

@ahaywood ahaywood commented Jun 30, 2023

Notion Task

Feature description

Updated storybook stories for CSF 3

  • Updated stories for cells, components, layouts, and pages

Tested TypeScript

  • cells
  • components
  • layouts
  • pages

Tested JavaScript

  • cells
  • components
  • layouts
  • pages

@ahaywood
Copy link
Contributor Author

@jtoar Is there a way to test the generators?

@jtoar
Copy link
Contributor

jtoar commented Jun 30, 2023

@ahaywood you can always use yarn rwfw project:sync on a Redwood project, but that takes a few minute to set up. With the CLI, sometimes you can get away with doing node ./dist/index.js --cwd ~/my/redwood/project generate ... in the CLI package, kind of like what you had to do for create-redwood-app. The full steps for that:

cd redwood
yarn install
yarn build
cd packages/cli
node ./dist/index.js --cwd ~/my/redwood/project generate cell ...
# see the cell in the redwood project

If you make any changes, you'll have to build again. Here's a short video that shows what I mean a little more clearly: https://www.loom.com/share/bcd664c6de4d40fa8229767440657231

@ahaywood
Copy link
Contributor Author

ahaywood commented Jul 5, 2023

@jtoar I updated the cell story and tested everything in a TS and JS project. Ready for your review.

@ahaywood ahaywood requested a review from jtoar July 5, 2023 21:07
@jtoar jtoar added this to the v6.0.0 milestone Jul 5, 2023
@jtoar jtoar added the release:fix This PR is a fix label Jul 5, 2023
- rm semi colons
- newlines
- no space in braces
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahaywood! This is more than enough for the v6 RC. Two small comments and this is good to merge after we update the snapshots for the tests.

@jtoar jtoar enabled auto-merge (squash) July 6, 2023 21:06
@jtoar jtoar disabled auto-merge July 6, 2023 21:34
@jtoar jtoar merged commit ddc3f3d into redwoodjs:main Jul 6, 2023
11 of 12 checks passed
jtoar pushed a commit that referenced this pull request Jul 6, 2023
[Notion
Task](https://www.notion.so/redwoodjs/generators-to-CSF-3-444966a53e5a462eab5d4c3f093ebbb3?pvs=4)

## Feature description

Updated storybook stories for CSF 3

- Updated stories for cells, components, layouts, and pages

Tested TypeScript
- [x] cells 
- [x] components
- [x] layouts
- [x] pages

Tested JavaScript
- [x] cells 
- [x] components
- [x] layouts
- [x] pages
Tobbe added a commit that referenced this pull request Sep 14, 2023
This updates the test-project rebuild script to be aligned with the
changes introduced in #8788
jtoar pushed a commit that referenced this pull request Sep 18, 2023
This updates the test-project rebuild script to be aligned with the
changes introduced in #8788
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants