fix(cli): Telemetry improvements #8798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
@Josh-Walker-GM looks good to me! My comments are mostly just nits so feel free to ignore
jtoar
pushed a commit
that referenced
this pull request
Jul 4, 2023
**Changes** 1. Telemetry is automatically closed after 5 minutes to ensure long running commands still send their data in a timely fashion. 2. The sender is more robust to glitched telemetry files. 3. Removed the verbose flag logic and now 8 files of telemetry are kept by default. 4. Added additional notes to the `telemetry.out.log` 5. Records the command as `--help` or `--version` if those flags are passed. This is because we will never hit a handler in that case so `command` would be blank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
telemetry.out.log--helpor--versionif those flags are passed. This is because we will never hit a handler in that case socommandwould be blank.