Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structure: Update lru-cache to v7 to minimize project:copy issues #8805

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 1, 2023

The lru-cache package version seems to be upgraded when running project:copy, causing issues for @redwoodjs/structure. This PR upgrades to v7 which lets us update the syntax we use when calling the LRU() constructor to be compatible with the version of lru we get by running project:copy

Fixes #8734

@Tobbe Tobbe added the release:chore This PR is a chore (means nothing for users) label Jul 1, 2023
@Tobbe Tobbe added this to the v6.0.0 milestone Jul 1, 2023
@Tobbe Tobbe requested a review from jtoar July 1, 2023 09:22
@Tobbe Tobbe merged commit f9912af into redwoodjs:main Jul 1, 2023
29 of 33 checks passed
@Tobbe
Copy link
Member Author

Tobbe commented Jul 1, 2023

@jtoar Feel free to revert this if you want. I just got fed up with seeing this error message all the time when working on other things and wasn't sure when you'd be working again (seeing as it's the weekend and we all shouldn't be working 😆)

@Tobbe Tobbe deleted the tobbe-lru-cache-7 branch July 1, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lru-cache version issue when using project:copy
1 participant