Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cleaning web" is only needed for Webpack #8807

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 1, 2023

In v6 having no bundler configured means you're using Vite, and should not need to clean web before building. Only when the bundler is explicitly set to 'webpack' should this task be executed.

This change also makes it easier to find this code later, when we need to remove all Webpack related code.

@Tobbe Tobbe added the release:fix This PR is a fix label Jul 1, 2023
@Tobbe Tobbe added this to the v6.0.0 milestone Jul 1, 2023
@Tobbe Tobbe enabled auto-merge (squash) July 1, 2023 13:11
@Tobbe Tobbe merged commit 7c1029d into redwoodjs:main Jul 1, 2023
29 of 33 checks passed
@Tobbe Tobbe deleted the tobbe-only-clean-webpack branch July 1, 2023 13:51
jtoar pushed a commit that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant