Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Revert change to prisma error message #8825

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
Prisma handles it's own error messaging so we don't want to throw to the top level try catch in that case.

Changes

  1. Restores the try catch in the handler.

@jtoar - Address the problem you raised. I'm not sure the milestone for this one.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label Jul 4, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar July 4, 2023 14:01
@jtoar jtoar added this to the v6.0.0 milestone Jul 4, 2023
@jtoar jtoar merged commit 875ad73 into main Jul 4, 2023
12 checks passed
@jtoar jtoar deleted the jgmw-cli/revert-prisma-trycatch branch July 4, 2023 16:18
jtoar pushed a commit that referenced this pull request Jul 4, 2023
**Problem**
Prisma handles it's own error messaging so we don't want to throw to the
top level try catch in that case.

**Changes**
1. Restores the try catch in the handler.

@jtoar - Address the problem you raised. I'm not sure the milestone for
this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants