Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add babel plugin to internal deps #8830

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 5, 2023

Trying to make test-project generation work

Currently erroring out on

Error in script: Cannot find module '@babel/plugin-proposal-private-methods'
Require stack:
- /Users/dac09/Experiments/xxx/node_modules/@babel/core/lib/config/files/plugins.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/core/lib/config/files/index.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/core/lib/index.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/register/lib/worker/babel-core.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/register/lib/worker/handle-message.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/register/lib/worker-client.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/register/lib/node.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/register/lib/nodeWrapper.js
- /Users/dac09/Experiments/xxx/node_modules/@babel/register/lib/index.js
- /Users/dac09/Experiments/xxx/node_modules/@redwoodjs/internal/dist/build/babel/common.js
- /Users/dac09/Experiments/xxx/node_modules/@redwoodjs/internal/dist/build/babel/api.js
- /Users/dac09/Experiments/xxx/node_modules/@redwoodjs/cli/dist/commands/execHandler.js
- Did you mean "@babel/plugin-transform-private-methods"?

@Tobbe Tobbe added release:fix This PR is a fix release:chore This PR is a chore (means nothing for users) and removed release:fix This PR is a fix labels Jul 5, 2023
@Tobbe Tobbe added this to the chore milestone Jul 5, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we could remove it from core too?

@Tobbe Tobbe enabled auto-merge (squash) July 5, 2023 23:39
@Tobbe Tobbe merged commit dc3064e into redwoodjs:main Jul 6, 2023
29 checks passed
@Tobbe Tobbe deleted the tobbe-babel-plugin-fix branch July 6, 2023 00:19
@jtoar jtoar modified the milestones: chore, v6.0.0 Jul 6, 2023
jtoar pushed a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants