Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes and simplifies the Countdown subscription example for Realtime #8838

Merged
merged 3 commits into from
Jul 6, 2023
Merged

fix: Fixes and simplifies the Countdown subscription example for Realtime #8838

merged 3 commits into from
Jul 6, 2023

Conversation

dthyresson
Copy link
Contributor

@dthyresson dthyresson commented Jul 6, 2023 •
edited

This PR fixes the issue where:

  • the countdown example actually uses the interval to count down by ... and
  • also has a reasonable count pause

@dthyresson dthyresson added the release:feature This PR introduces a new feature label Jul 6, 2023
@dthyresson dthyresson self-assigned this Jul 6, 2023
@dthyresson dthyresson modified the milestones: next-release, v6.0.0 Jul 6, 2023
Josh-Walker-GM
Josh-Walker-GM approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and it works fine.

I was going to get defensive about passing in negative intervals and stuff but this is just an example to the user.

@dthyresson
Copy link
Contributor Author

LGTM, tested locally and it works fine.

I was going to get defensive about passing in negative intervals and stuff but this is just an example to the user.

That's a good point. But as is an example, they can try and making mistakes is a good way to learn. :)

@dthyresson dthyresson enabled auto-merge (squash) July 6, 2023 15:00
@dthyresson dthyresson merged commit 1368550 into redwoodjs:main Jul 6, 2023
29 checks passed
jtoar pushed a commit that referenced this pull request Jul 6, 2023
@dthyresson @jtoar
fix: Fixes and simplifies the Countdown subscription example for Real…
5568ecf 
…time (#8838)

This PR fixes the issue where: 

* the countdown example actually uses the interval to count down by ...
and
*  also has a reasonable count pause
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Assignees

@dthyresson dthyresson

Labels
release:feature This PR introduces a new feature
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dthyresson @Josh-Walker-GM