-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@redwoodjs/web-server #8916
@redwoodjs/web-server #8916
Conversation
…to tobbe-fe-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and the web side works as expected. I did not test every possible combination of experimental features.
Heads up that I'm not going to cherry pick this just yet to v6 so I changed the milestone, though this totally could land in the v6 RC or a minor, etc. |
@jtoar Good call! |
Hey, I'm a bit confused by this, as you only mention |
@razzeee yeah you're right. This will be for serve too. This was inspired by our work on better docker support - a priority for us. We are now looking to get parity between the way we serve web and api sides. We already had an api-server package but we lacked a similar package for web. This complicated things all over the place with many different entry points and ambiguous dependencies. We've got even more refactoring work going on behind the scenes to tidy up this area of the code so hopefully this will all come together coherently in a month or so. |
Yeah, I'm aware of the work going on, was just wondering, if I could already migrate parts of my docker file/flow. |
Add a new server for the Web side that docker files can use to serve the web side of a RW project without depending on other big RW packages like cli or internal.
The goal is that this should be a non-breaking change. If it's not, I need to fix that.
Currently, as this PR stands, the new web-server package will only be used when you run
yarn rw dev web
and the SSR experimental features is not enabled. If you runyarn rw dev
the old way of serving web is still used (couldn't switch to the new web-server package without breaking backwards compatibility)The new web-server package is added as a dependency to
@redwoodjs/core
so that RW projects get access to it (for runningyarn rw dev web
. The options here were to either make it a dependency of core or cli. But it's core that has it listed as a bin, so I opted to put it in the deps for core. (api-server is also a bin in core, but it's listed as a dep in cli. And it works, because cli is a dep of core, but I don't think it's totally correct.)