fix(firebase): improve error handling #8976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
added a commit
that referenced
this pull request
Jul 27, 2023
Auditing firebase again for Redwood's v6 release, it was failing and I forgot why. Referring back to #8305 reminded me that the versions of `firebase-admin` between the framework and a user's project need to be the same. One of the ways they get out of sync is with renovate. I don't want to read from the firebase api package during the firebase setup command—plus the versions can get out of sync in other ways—so for now, may as well save everyone some time by making the error more explicit: <img width="2012" alt="image" src="https://github.com/redwoodjs/redwood/assets/32992335/f1090965-5199-42d5-8831-3978e9a68050"> This coupling really isn't ideal at all since any time we bump the version of `firebase-admin` in the framework and release a new versoin, users have to bump it in their projects too. I'm not sure what a better way is yet. I've also upgraded the version of `firebase` (the package used on the web side) that the setup command installs to v10 since it worked locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditing firebase again for Redwood's v6 release, it was failing and I forgot why. Referring back to #8305 reminded me that the versions of
firebase-adminbetween the framework and a user's project need to be the same. One of the ways they get out of sync is with renovate. I don't want to read from the firebase api package during the firebase setup command—plus the versions can get out of sync in other ways—so for now, may as well save everyone some time by making the error more explicit:This coupling really isn't ideal at all since any time we bump the version of
firebase-adminin the framework and release a new versoin, users have to bump it in their projects too. I'm not sure what a better way is yet.I've also upgraded the version of
firebase(the package used on the web side) that the setup command installs to v10 since it worked locally.