fix(v6): stub @storybook/react types till @redwoodjs/cli-storybook is installed
#9027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
changed the title
@storybook/react types till storybook is installed
jtoar
changed the title
@storybook/react types till storybook is installed@storybook/react types till @redwoodjs/cli-storybook is installed
Tobbe
approved these changes
Aug 16, 2023
dac09
reviewed
Aug 18, 2023
dac09
approved these changes
Aug 22, 2023
|
Thanks for humoring my questions both 👍👍👍. I'll let you merge! |
jtoar
added a commit
that referenced
this pull request
Sep 2, 2023
…` is installed (#9027) Supersedes #9015. In v6, we decoupled Storybook from the framework. But generators still generate stories. If a user hasn't set up Storybook, but generates a page, etc (which is pretty much what happens in the tutorial), they'll see a type error in the `*.stories.{tsx,jsx}` file. See https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/35. Ideally, we just wouldn't generate stories if a user hasn't set up Storybook. But the tutorial is written as if these story files were just around this whole time, which is how the framework has worked and works. I think we can eventually get to the point where Storybook is fully decoupled, but I don't have a good idea of the amount of work that would need to be done, and am already focused on other projects (Docker). So this seems like the simplest fix for now without undoing the work we did. @Tobbe had the idea here of stubbing the types till the `@redwoodjs/cli-storybook` is installed. --------- Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com> Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
jtoar
added a commit
that referenced
this pull request
Sep 2, 2023
…` is installed (#9027) Supersedes #9015. In v6, we decoupled Storybook from the framework. But generators still generate stories. If a user hasn't set up Storybook, but generates a page, etc (which is pretty much what happens in the tutorial), they'll see a type error in the `*.stories.{tsx,jsx}` file. See https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/35. Ideally, we just wouldn't generate stories if a user hasn't set up Storybook. But the tutorial is written as if these story files were just around this whole time, which is how the framework has worked and works. I think we can eventually get to the point where Storybook is fully decoupled, but I don't have a good idea of the amount of work that would need to be done, and am already focused on other projects (Docker). So this seems like the simplest fix for now without undoing the work we did. @Tobbe had the idea here of stubbing the types till the `@redwoodjs/cli-storybook` is installed. --------- Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com> Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #9015.
In v6, we decoupled Storybook from the framework. But generators still generate stories. If a user hasn't set up Storybook, but generates a page, etc (which is pretty much what happens in the tutorial), they'll see a type error in the
*.stories.{tsx,jsx}file. See https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/35.Ideally, we just wouldn't generate stories if a user hasn't set up Storybook. But the tutorial is written as if these story files were just around this whole time, which is how the framework has worked and works.
I think we can eventually get to the point where Storybook is fully decoupled, but I don't have a good idea of the amount of work that would need to be done, and am already focused on other projects (Docker). So this seems like the simplest fix for now without undoing the work we did.
@Tobbe had the idea here of stubbing the types till the
@redwoodjs/cli-storybookis installed.