Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore(eslint): prefer node protocol #9057

Conversation

virtuoushub
Copy link
Collaborator

@virtuoushub virtuoushub commented Aug 22, 2023

currently blocked

closing as blocked by downstream dependency on jest. see also: jestjs/jest#14297

once jest supports this, or redwood uses a different test framework that supports the node protocol we can revisit.

source


When importing builtin modules, it's better to use the node: protocol as it makes it perfectly clear that the package is a Node.js builtin module.

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md

Preliminary work to aid in ESM migration.

@virtuoushub virtuoushub force-pushed the virtuoushub/esm/eslint/eslint-plugin-unicorn/prefer-node-protocol branch from b309047 to 54399c9 Compare August 22, 2023 23:50
@virtuoushub
Copy link
Collaborator Author

Failing due to jestjs/jest#14040

@thedavidprice
Copy link
Contributor

@virtuoushub I just read through jestjs/jest#14332 Doesn't look like this is going to come through anytime soon. Any thoughts about initiating a Jest patch following advice in this comment? If it works, you could open a PR back into Jest.

@virtuoushub virtuoushub force-pushed the virtuoushub/esm/eslint/eslint-plugin-unicorn/prefer-node-protocol branch from 54399c9 to 8a68efb Compare August 28, 2023 21:09
@virtuoushub virtuoushub changed the title chore(eslint): prefer node protocol [WIP] chore(eslint): prefer node protocol Aug 29, 2023
@virtuoushub virtuoushub marked this pull request as draft August 29, 2023 03:27
@virtuoushub
Copy link
Collaborator Author

virtuoushub commented Sep 13, 2023

Failing due to jestjs/jest#14040

unblocked this via yarn patching in jest draft PR: jestjs/jest#14332

this approach is brittle, and ideally jest fixes it, but in the meantime this should work. It does mean anytime jest is updated we need to propagate the patch forward until jest fixes it in upstream. didn't work.

@virtuoushub
Copy link
Collaborator Author

closing as blocked by downstream dependency on jest. see also: jestjs/jest#14297

once jest supports this, or redwood uses a different test framework that supports the node protocol we can revisit.

@virtuoushub virtuoushub closed this Dec 6, 2023
virtuoushub added a commit to virtuoushub/redwood that referenced this pull request Dec 12, 2023
virtuoushub added a commit to virtuoushub/redwood that referenced this pull request Dec 12, 2023
@virtuoushub virtuoushub mentioned this pull request Dec 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants