Limit the directories searched through for directory named modules #9079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
reviewed
Aug 28, 2023
|
Thanks for this @bnn1 - just a small comment, then we can merge. Please ping if it falls of our radar :) |
1 task
jtoar
pushed a commit
that referenced
this pull request
Sep 2, 2023
jtoar
pushed a commit
that referenced
this pull request
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duplicate of this PR: #8763
previous pr got closed due to branch rename, sorry
This PR limits the directories that RW searches through when running generators.
It is meant to fix an issue where RW tries to scan directories with restricted permissions, resulting in generation failure.
the pr also adds documentation to functions related to finding directory named modules and comments out a function that is exported but is not used anywhere in the project.
addresses #7761