style(eslint): enable @typescript-eslint/consistent-type-imports

[virtuoushub]

Enable a mostly stylistic lint rule. Will help with ESM conversion by helping differentiate type imports vs regular. This difference helps with false positives for the import/no-extraneous-dependencies rule ( #9081 ). That rule is what ultimately helps surface possible ESM issues/bundle bloat.

see also:

• https://gist.github.com/Jaid/164668c0151ae09d2bc81be78a203dd5
• https://stackoverflow.com/a/64243357

---

note: due to the broad nature of these changes, this can impact inflight PRs. hopefully any possible conflicts that arise are easy enough to fix via a "take your PRs changes" and then run yarn lint:fix merge strategy. Happy to help resolve any issues this PR might introduce to other inflight PRs, if it does get accepted/merged.

[virtuoushub]

@Tobbe is there a reason to use import('vite'). here in this file?

[virtuoushub]

gentle bump to @Tobbe - this is a fairly broad PR so the longer it stays open, the more painful the merge conflicts can become.

[Tobbe]

This is code I mostly copy/pasted from another project. Looks like import type { ModuleNode } from 'vite' should take care of the type here. Your change looks good

[virtuoushub]

thanks for double checking!

[virtuoushub]

@jtoar

This PR changes the create-redwood-app TS template.
That usually means the JS template needs to be rebuilt.
If you know that it doesn't, add the "crwa-ok" label. Otherwise, rebuild the JS template and commit the changes:

cd packages/create-redwood-app
yarn ts-to-js

pretty sure these changes do not require any JS template rebuild. I followed the above instructions locally, and no changes were produced.

[jtoar]

@virtuoushub can I resolve the merge conflicts for you here?

[virtuoushub]

@virtuoushub can I resolve the merge conflicts for you here?

Hi @jtoar , thanks however I already did. What is odd is it looks like yarn lint:fix is currently broken: #8572 (comment) I had not built the latest after pulling in #8572 which is why I was seeing that error.

[jtoar]

Hey @virtuoushub, scanned these changes as best I could. Awesome work! I love where you're headed—I can't wait for the import/no-extraneous-dependencies rule. 🙏

I caught a few changes to the test project fixture that should be reverted. This is my miss, I need to update the script that rebuilds the test project fixture. We want to keep those stories the way they are. I commented on the files

[jtoar]

LGTM pending the test project fixture changes and the question for @Tobbe.

[virtuoushub]

LGTM pending the test project fixture changes and the question for @Tobbe.

test project fixture changes are in.

[virtuoushub]

fwiw it looks like there is an unrelated to these changes flakey test:

FAIL   code  src/__tests__/router.test.tsx (50.835 s)
  ● slow imports › usePageLoadingContext

    expect(element).not.toBeInTheDocument()

    expected document not to contain element, found <p>loading in page...</p> instead

      536 |       // This shouldn't show up, because the page shouldn't render before it's
      537 |       // fully loaded
    > 538 |       expect(screen.queryByText('loading in page...')).not.toBeInTheDocument()
          |                                                            ^
      539 |
      540 |       await waitFor(() => screen.getByText('done loading in page'))
      541 |       await waitFor(() => screen.getByText('done loading in layout'))

      at Object.toBeInTheDocument (src/__tests__/router.test.tsx:538:60)

see: https://github.com/redwoodjs/redwood/actions/runs/6032779642/job/16368480189#step:10:342

[Tobbe]

LGTM (only scanned the code, didn't try it)