Support jsx/tsx on the api side (for mail templates, ai-jsx, etc) #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:breaking
jtoar
pushed a commit
that referenced
this pull request
Sep 6, 2023
) This is needed to support JSX email templates like ```jsx import { Button } from '@react-email/button'; const Email = () => { return ( <Button href="https://example.com" style={{ color: '#61dafb' }}> Click me </Button> ); }; ``` and also ai-jsx code like ```jsx /** @jsxImportSource ai-jsx */ // ... toStreamResponse( <ChatCompletion temperature={1}> <UserMessage>Write me a poem about {topic}</UserMessage> </ChatCompletion> ).body ``` The `jsx` tsconfig setting needs to be `react-jsx` to support the `jsxImportSource` setting: https://www.typescriptlang.org/tsconfig#jsxImportSource The babel jsx plugin setting needs to be `automatic` to support `jsxImportSource` comments: https://babeljs.io/docs/babel-plugin-transform-react-jsx#customizing-the-automatic-runtime-import --- @jtoar This one isn't breaking, but it does need codemods. So I added the `feature-breaking` label to make sure we don't forget about those. (Feel free to remove that label again if you have a better way of keeping track)
jtoar
added a commit
that referenced
this pull request
Sep 13, 2023
#9133 included changes to story files in the test project fixture. The test project rebuild script doesn't respect these changes, which I had to make manually to better conform to the new story format. Unfortunately it's just something I've been keeping an eye on which isn't sustainable. Just reverting them for now so CI is testing the right thing.
jtoar
added a commit
that referenced
this pull request
Sep 18, 2023
#9133 included changes to story files in the test project fixture. The test project rebuild script doesn't respect these changes, which I had to make manually to better conform to the new story format. Unfortunately it's just something I've been keeping an eye on which isn't sustainable. Just reverting them for now so CI is testing the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support JSX email templates like
and also ai-jsx code like
The
jsxtsconfig setting needs to bereact-jsxto support thejsxImportSourcesetting: https://www.typescriptlang.org/tsconfig#jsxImportSourceThe babel jsx plugin setting needs to be
automaticto supportjsxImportSourcecomments: https://babeljs.io/docs/babel-plugin-transform-react-jsx#customizing-the-automatic-runtime-import@jtoar This one isn't breaking, but it does need codemods. So I added the
feature-breakinglabel to make sure we don't forget about those. (Feel free to remove that label again if you have a better way of keeping track)