fix(cli): Ensure newline to prevent error output boxen misalignment #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
force-pushed
the
jgmw-cli/fix-error-output
branch
from
519281e
to
f2126d2
Compare
|
Hey Josh, the exit code you’re looking for is 130, probably a mac thing? It’s a valid code that should be ignored I think - wrapping all our Execa would be a big anti pattern imo. You can try this on mac with any longer running command that uses execa - generate, migrate, setup, etc. and cancel it midway I think! You wont see it if listr pops up... it must be handling the error code for us. |
dac09
approved these changes
Sep 6, 2023
Closed
1 task
thedavidprice
pushed a commit
that referenced
this pull request
Sep 8, 2023
…9135) **Problem** When invoking a ctrl+c the boxen error output is misaligned. **Fix** Just print a newline before the boxen encased error output. **Future** @dac09 - This at least solves the misalignment. It doesn't address the issue with the error showing when it's not really appropriate. I think that might be more appropriately dealt with by directly try-catching the execa call where it is called. I have tried on all three platforms: * Windows - I get `Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'e:'` so I can't really debug further until I address that. * Ubuntu - I don't get any error output shown but the process does exit with an error code 129. * Mac - I just got a MacBook so I can now test this case - even though I feel like a child because I have no idea of to use a mac effectively yet. I do get the error output but I got an exit code 1. I'll take a further attempt at debugging this cross platform exit code stuff when I'm a little more familiar with mac. One thing to note is that @jtoar and I already had a similar issue where execa/storybook itself behaved differently on mac, windows & ubuntu so we might be a little at the whims of our dependencies with this. TLDR - Boxen output fixed. Excessive error output I'll fix in a future PR because it'll be a more carefully thought out change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When invoking a ctrl+c the boxen error output is misaligned.
Fix
Just print a newline before the boxen encased error output.
Future
@dac09 - This at least solves the misalignment. It doesn't address the issue with the error showing when it's not really appropriate. I think that might be more appropriately dealt with by directly try-catching the execa call where it is called.
I have tried on all three platforms:
Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'e:'so I can't really debug further until I address that.I'll take a further attempt at debugging this cross platform exit code stuff when I'm a little more familiar with mac. One thing to note is that @jtoar and I already had a similar issue where execa/storybook itself behaved differently on mac, windows & ubuntu so we might be a little at the whims of our dependencies with this.
TLDR - Boxen output fixed. Excessive error output I'll fix in a future PR because it'll be a more carefully thought out change.