Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.md #9189

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Update services.md #9189

merged 4 commits into from
Sep 18, 2023

Conversation

papaponmx
Copy link
Contributor

I've removed duplicated code

Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @papaponmx!

@jtoar jtoar added the release:docs This PR only updates docs label Sep 18, 2023
@jtoar jtoar added this to the next-release milestone Sep 18, 2023
@jtoar jtoar merged commit ba9461c into redwoodjs:main Sep 18, 2023
20 of 22 checks passed
@papaponmx papaponmx deleted the patch-1 branch September 18, 2023 18:16
jtoar pushed a commit that referenced this pull request Sep 18, 2023
I've removed duplicated code
@pvenable
Copy link
Contributor

FWIW I don't think this was duplicate code per se. It was showing two different ways of throwing errors, and without both examples the next sentence doesn't make much sense anymore:

Either of these errors will be caught and re-thrown as a ServiceValidationError with your text as the message of the error (although technically you should always throw errors with new Error() like in the second example).

@jtoar
Copy link
Contributor

jtoar commented Sep 19, 2023

thanks for catching that @pvenable totally missed it. maybe we need to add a comment in the codeblock that highlights the difference a bit. but will revert!

jtoar added a commit that referenced this pull request Sep 19, 2023
jtoar added a commit that referenced this pull request Sep 19, 2023
jtoar added a commit that referenced this pull request Sep 19, 2023
@jtoar jtoar modified the milestones: next-release, v6.3.0 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants